Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #367: Images for review cards #416

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Fix #367: Images for review cards #416

merged 2 commits into from
Nov 19, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 19, 2019

Explanation

This PR makes sure that each skill card in Topic Review Tab has a skill thumbnail.

Images in Fractions Topic

Screenshot_1574150904

Default Image

Screenshot_1574150899

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 19, 2019

@BenHenning PTAL at the description images.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Nov 19, 2019
@rt4914 rt4914 removed the request for review from BenHenning November 19, 2019 09:32
@rt4914 rt4914 merged commit 6c0b771 into develop Nov 19, 2019
@rt4914 rt4914 deleted the review-cards-with-images branch November 19, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants