Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3535: Merge hints_and_solution_fragment.xml into one file #4181

Conversation

adizcode
Copy link
Contributor

Explanation

Fixes #3535 by merging 4 different layout files into one

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Before After

@oppiabot
Copy link

oppiabot bot commented Feb 14, 2022

Unassigning @vrajdesai78 since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Feb 14, 2022

Assigning @rt4914 for code owner reviews. Thanks!

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rt4914 rt4914 enabled auto-merge (squash) February 14, 2022 13:37
@oppiabot oppiabot bot unassigned rt4914 Feb 14, 2022
@oppiabot
Copy link

oppiabot bot commented Feb 14, 2022

Unassigning @rt4914 since they have already approved the PR.

@rt4914 rt4914 merged commit a709655 into oppia:develop Feb 14, 2022
@adizcode adizcode deleted the merge-hints-and-solution-fragment-into-single-file branch February 16, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge hints_and_solution_fragment.xml into single xml file
3 participants