Fixes #4185: Added Dark Mode for HelpActivity , FaqListActivity , FaqSingleActivity #4245

bhaktideshmukh · 2022-03-13T12:03:02Z

Explanation

Fixes #4185
Added dark mode for HelpActivity , FaqListActivity , FaqSingleActivity.

Mocks Link

ScreenShots

Default mode	After dark mode

Default mode	After dark mode

Default mode	After dark mode

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

ayush0402 · 2022-03-13T13:37:37Z

@bhaktideshmukh Haven't looked at the changes yet but also update the color for ActionBar to the correct color. You might want to look at the theme in the manifest that this screen is using and refer to OppiaActionBarTheme we are currently using for another theme for this.

bhaktideshmukh · 2022-03-14T03:06:25Z

@bhaktideshmukh Haven't looked at the changes yet but also update the color for ActionBar to the correct color. You might want to look at the theme in the manifest that this screen is using and refer to OppiaActionBarTheme we are currently using for another theme for this.

Do you mean to update 'android:theme="@style/Widget.AppCompat.ActionBar" ' to 'android:theme="@style/OppiaThemeWithoutActionBar" in the toolbar section.

rt4914 · 2022-03-14T10:05:45Z

Un-assigning until approved / re-assigned by @ayush0402

ayush0402 · 2022-03-14T14:27:51Z

@bhaktideshmukh We are not supposed to change anything directly in the manifest file. If you look at the current declaration of OppiaTheme it will have something like <item name="actionBarTheme">@style/OppiaActionBarTheme</item> to set the ActionBar color.
But I guess FAQ Activity is not actually using ActionBar but instead using a custom Toolbar in its layout file. So we just might need to change that.

bhaktideshmukh · 2022-03-14T17:48:31Z

@bhaktideshmukh We are not supposed to change anything directly in the manifest file. If you look at the current declaration of OppiaTheme it will have something like <item name="actionBarTheme">@style/OppiaActionBarTheme</item> to set the ActionBar color. But I guess FAQ Activity is not actually using ActionBar but instead using a custom Toolbar in its layout file. So we just might need to change that.

I have updated the theme in Faq_list_activity.xml -- is this what you suggested?

current view:--
||

bhaktideshmukh · 2022-03-16T16:55:06Z

PTAL @ayush0402
Thanks

oppiabot · 2022-03-23T17:10:59Z

Hi @bhaktideshmukh, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

ayush0402

@bhaktideshmukh Thanks, overall this looks good. Just had a few suggestions.
Also, I think the content of the FAQ and other list items in FAQ questions list should be using sub_text color (which is defined in color_defs as color_def_oppia_silver.) and not the Body Header color, you might need to confirm this from the mocks and let me know if It is actually mentioned otherwise in the mocks.

ayush0402 · 2022-03-23T20:28:21Z

app/src/main/res/layout-sw600dp-land/faq_single_activity.xml

-        android:background="?attr/colorPrimary"
+        android:background="@color/color_def_oppia_green"


This should be a component_color.

ayush0402 · 2022-03-23T20:30:41Z

app/src/main/res/layout/faq_list_activity.xml

-        android:background="@color/oppia_primary"
+        android:background="@color/color_def_oppia_green"


ayush0402 · 2022-03-23T20:31:00Z

app/src/main/res/layout/faq_single_activity.xml

-        android:background="?attr/colorPrimary"
+        android:background="@color/color_def_oppia_green"


@bhaktideshmukh Thanks, overall this looks good. Just had a few suggestions. Also, I think the content of the FAQ and other list items in FAQ questions list should be using sub_text color (which is defined in color_defs as color_def_oppia_silver.) and not the Body Header color, you might need to confirm this from the mocks and let me know if It is actually mentioned otherwise in the mocks.

Content of FAQ in mocks is mentioned as 'oppia_primary_text'.

oppiabot · 2022-03-23T20:59:03Z

Unassigning @ayush0402 since the review is done.

oppiabot · 2022-03-23T20:59:06Z

Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @ayush0402. PTAL. Thanks!

bhaktideshmukh · 2022-05-17T11:28:16Z

@bhaktideshmukh In screenshots dividers are not visible. Mostly because you have removed the drawable. Mostly @Akshatkamboj14 's PRs should help how he fixed the divider issue and once his PRs gets merged I think you won't need to fix it specifically.

This divider issue is still pending.

app/src/main/res/layout/help_item.xml

app/src/main/res/layout/faq_single_activity.xml

app/src/main/res/layout/faq_content.xml

oppiabot · 2022-05-18T05:21:57Z

Unassigning @Akshatkamboj14 since the review is done.

oppiabot · 2022-05-18T05:22:00Z

Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @Akshatkamboj14. PTAL. Thanks!

rt4914

@bhaktideshmukh Please separate FAQListActivity colors from FAQSingleActivity colors correctly.

app/src/main/res/layout-sw600dp-land/faq_single_activity.xml

app/src/main/res/layout/faq_content.xml

app/src/main/res/values/component_colors.xml

rt4914

LGTM, Thanks.

added dark_mode to help and faq

12f7ade

bhaktideshmukh requested a review from rt4914 as a code owner March 13, 2022 12:03

bhaktideshmukh assigned rt4914 and ayush0402 Mar 13, 2022

bhaktideshmukh changed the title ~~added dark_mode to help and faq~~ Fixes #4185: Added Dark Mode for HelpActivity , FaqListActivity , FaqSingleActivity Mar 13, 2022

ayush0402 assigned bhaktideshmukh and unassigned ayush0402 Mar 13, 2022

bhaktideshmukh assigned ayush0402 and unassigned bhaktideshmukh Mar 14, 2022

rt4914 removed their assignment Mar 14, 2022

ayush0402 assigned bhaktideshmukh Mar 14, 2022

updated theme

f7f1237

bhaktideshmukh removed their assignment Mar 14, 2022

updated toolbar color

3a60386

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 23, 2022

ayush0402 suggested changes Mar 23, 2022

View reviewed changes

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 23, 2022

oppiabot bot unassigned ayush0402 Mar 23, 2022

oppiabot bot assigned bhaktideshmukh Mar 23, 2022

added toolbar_color to component_colors

fa62229

bhaktideshmukh assigned ayush0402 Mar 28, 2022

updated color names

c17a7c5

Merge branch 'develop' into faq_dark_mode

c0ab9cf

bhaktideshmukh assigned rt4914 and unassigned bhaktideshmukh May 17, 2022

rt4914 reviewed May 17, 2022

View reviewed changes

app/src/main/res/layout/help_item.xml Show resolved Hide resolved

added divider in help_item

afaba88

bhaktideshmukh assigned Akshatkamboj14 and aayushimathur6 May 18, 2022

bhaktideshmukh requested review from aayushimathur6 and Akshatkamboj14 May 18, 2022 05:17

Akshatkamboj14 suggested changes May 18, 2022

View reviewed changes

app/src/main/res/layout/faq_single_activity.xml Outdated Show resolved Hide resolved

app/src/main/res/layout/faq_content.xml Show resolved Hide resolved

oppiabot bot unassigned Akshatkamboj14 May 18, 2022

oppiabot bot assigned bhaktideshmukh May 18, 2022

bhaktideshmukh assigned Akshatkamboj14 and unassigned bhaktideshmukh May 18, 2022

rt4914 suggested changes May 24, 2022

View reviewed changes

app/src/main/res/layout-sw600dp-land/faq_single_activity.xml Outdated Show resolved Hide resolved

app/src/main/res/layout/faq_content.xml Outdated Show resolved Hide resolved

rt4914 assigned bhaktideshmukh and unassigned rt4914 May 24, 2022

Akshatkamboj14 reviewed May 24, 2022

View reviewed changes

app/src/main/res/values/component_colors.xml Outdated Show resolved Hide resolved

bhaktideshmukh and others added 3 commits May 26, 2022 09:11

seperated faqlist and faqsingle

a6a3efc

Merge branch 'develop' into faq_dark_mode

35bc489

resolved conflicts

e435e5f

bhaktideshmukh assigned rt4914 and unassigned bhaktideshmukh May 26, 2022

rt4914 approved these changes May 27, 2022

View reviewed changes

rt4914 merged commit 09b3ba1 into oppia:develop May 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #4185: Added Dark Mode for HelpActivity , FaqListActivity , FaqSingleActivity #4245

Fixes #4185: Added Dark Mode for HelpActivity , FaqListActivity , FaqSingleActivity #4245

bhaktideshmukh commented Mar 13, 2022 •

edited

ayush0402 commented Mar 13, 2022

bhaktideshmukh commented Mar 14, 2022

rt4914 commented Mar 14, 2022

ayush0402 commented Mar 14, 2022

bhaktideshmukh commented Mar 14, 2022

bhaktideshmukh commented Mar 16, 2022

oppiabot bot commented Mar 23, 2022

ayush0402 left a comment

ayush0402 Mar 23, 2022

bhaktideshmukh Mar 28, 2022

ayush0402 Mar 23, 2022

ayush0402 Mar 23, 2022

bhaktideshmukh Mar 28, 2022

oppiabot bot commented Mar 23, 2022

oppiabot bot commented Mar 23, 2022

bhaktideshmukh commented May 17, 2022

oppiabot bot commented May 18, 2022

oppiabot bot commented May 18, 2022

rt4914 left a comment

rt4914 left a comment

		android:background="?attr/colorPrimary"
		android:background="@color/color_def_oppia_green"

		android:background="@color/oppia_primary"
		android:background="@color/color_def_oppia_green"

Fixes #4185: Added Dark Mode for HelpActivity , FaqListActivity , FaqSingleActivity #4245

Fixes #4185: Added Dark Mode for HelpActivity , FaqListActivity , FaqSingleActivity #4245

Conversation

bhaktideshmukh commented Mar 13, 2022 • edited

Explanation

Essential Checklist

For UI-specific PRs only

ayush0402 commented Mar 13, 2022

bhaktideshmukh commented Mar 14, 2022

rt4914 commented Mar 14, 2022

ayush0402 commented Mar 14, 2022

bhaktideshmukh commented Mar 14, 2022

bhaktideshmukh commented Mar 16, 2022

oppiabot bot commented Mar 23, 2022

ayush0402 left a comment

Choose a reason for hiding this comment

ayush0402 Mar 23, 2022

Choose a reason for hiding this comment

bhaktideshmukh Mar 28, 2022

Choose a reason for hiding this comment

ayush0402 Mar 23, 2022

Choose a reason for hiding this comment

ayush0402 Mar 23, 2022

Choose a reason for hiding this comment

bhaktideshmukh Mar 28, 2022

Choose a reason for hiding this comment

oppiabot bot commented Mar 23, 2022

oppiabot bot commented Mar 23, 2022

bhaktideshmukh commented May 17, 2022

oppiabot bot commented May 18, 2022

oppiabot bot commented May 18, 2022

rt4914 left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

bhaktideshmukh commented Mar 13, 2022 •

edited