Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #4251: Update app version name & codes for alpha MR4 #4349

Merged
merged 2 commits into from
May 6, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented May 6, 2022

Explanation

Fix part of #4251

This bumps the minor version & related version codes in preparation for cutting alpha MR4. Note that the extra '+4' is because we shipped a prerelease version of the app and didn't correspondingly commit the increment (normally we increment the version codes by +4 since there are 4 flavors built in each release, but we didn't account for the 4 used in the prerelease version).

Furthermore, alpha MR4 will include an extra version for an upcoming research study project, so the version codes will need to be incremented an extra '+1' next time (this is tracked by #4348).

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A

@BenHenning
Copy link
Sponsor Member Author

@seanlip PTAL.

/cc @ankita240796 for FYI.

@BenHenning BenHenning requested a review from seanlip May 6, 2022 07:46
@BenHenning BenHenning enabled auto-merge (squash) May 6, 2022 07:46
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHenning I am unable to understand the PR decription. It says +4 but the PR has +8

@BenHenning
Copy link
Sponsor Member Author

I updated the description to clarify @rt4914. PTAL and let me know if that's clear, or if more context is needed.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks

@BenHenning BenHenning merged commit 516241b into develop May 6, 2022
@BenHenning BenHenning deleted the update-version-for-alpha-mr4 branch May 6, 2022 09:07
@rt4914 rt4914 assigned BenHenning and unassigned rt4914 May 6, 2022
@oppiabot oppiabot bot assigned rt4914 and unassigned BenHenning May 6, 2022
@oppiabot
Copy link

oppiabot bot commented May 6, 2022

Unassigning @BenHenning since a re-review was requested. @BenHenning, please make sure you have addressed all review comments. Thanks!

@BenHenning
Copy link
Sponsor Member Author

Thanks @rt4914!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants