Fix #3453 & #3454: Optimise UI pin related screens - pin_password_activity, admin_auth_activity, admin_pin_activity

[rt4914]

Explanation

Fix #3453 & Fix #3454: Optimise UI pin related screens - pin_password_activity, admin_auth_activity, admin_pin_activity

All these mocks can be found from links given here: https://github.com/oppia/oppia-android/wiki/Working-on-UI

This is basically complete redesign of all three screens because the earlier implementations either had too-many files or were not optimised.

You can follow this video link to understand why and how I applied the designs https://youtu.be/fLP4bm3D6Cw

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

Pin Password Activity

Admin Auth Activity

Admin Pin Activity

RTL Screenshots

Note: There are some issues in screenshot but I have checked on develop and the results are same. There can be two issues here (a.) the emulator itself is unable to give correct results (b.) for stings which contain digit the translation is not working. In either case it will be investigated and solved as a separate issue.

[github-actions]

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 23 May 2022.

[oppiabot]

Hi @rt4914, it looks like some changes were requested on this pull request by @vrajdesai78. PTAL. Thanks!

[seanlip]

Approving per @rt4914's request since this needs a reviewer with write access to do so.

/cc @BenHenning FYI.

[yash10019coder]

LGTM @rt4914 just left a comment PTAL thanks

[yash10019coder]

why have you used -ive margin for match_parent ?

[rt4914]

Firstly, this is not the best industry practice but for our case it is the best solution.

Because we want to merge all files into one file but the issue is a view can be match_parent or 360dp (something fixed). Now in dimens.xml file we cannot mention match_parent directly but the equivalent of that is -2px and similarly -1px is wrap_content. This -2px is actually not a value that will get used instead it denotes that the OS has to use match_parent here.