Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4196: Add dark mode support for story activity, resume lesson activity and hints and solution fragment #4358

Conversation

Akshatkamboj14
Copy link
Member

@Akshatkamboj14 Akshatkamboj14 commented May 14, 2022

Explanation

Fixes #4196

Mocks Link:

Default Mode Dark Mode
image image
image image
image image
image image
image image

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 23 May 2022.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes. Mainly only use component_color colors in layout xml files.

Also please add screen shot of light/dark locked chapter in story_activity. Have a look at last item in this mock https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/5abb0ace-19ee-48b8-8154-919154f924d2/specs/

app/src/main/res/drawable/start_over_button_background.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-land/hints_summary.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-sw600dp-land/hints_summary.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-sw600dp/story_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-sw600dp/story_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/hints_summary.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/story_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/values/component_colors.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes. Mainly only use component_color colors in layout xml files.

@rt4914 rt4914 assigned Akshatkamboj14 and unassigned rt4914 May 17, 2022
… Add-dark-mode-support-for-StoryActivity-ResumeLessonActivity-and-HintsAndSolutionFragment
@Akshatkamboj14
Copy link
Member Author

@rt4914 I have made the suggested changes PTAL, thanks.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. There is just one issue, if you check the locked item, at the corners you can see white corners. That needs to be fixed.

@rt4914 rt4914 removed their assignment May 24, 2022
@Akshatkamboj14
Copy link
Member Author

@rt4914, I have made the necessary change and updated the mocks as well. PTAL

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 0f476f4 into oppia:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode support for StoryActivity, ResumeLessonActivity and HintsAndSolutionFragment
4 participants