-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4196: Add dark mode support for story activity, resume lesson activity and hints and solution fragment #4358
Conversation
… Add-dark-mode-support-for-StoryActivity-ResumeLessonActivity-and-HintsAndSolutionFragment
Thanks for submitting this pull request! Some main reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes. Mainly only use component_color
colors in layout xml files.
Also please add screen shot of light/dark locked chapter in story_activity. Have a look at last item in this mock https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/5abb0ace-19ee-48b8-8154-919154f924d2/specs/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes. Mainly only use component_color
colors in layout xml files.
… Add-dark-mode-support-for-StoryActivity-ResumeLessonActivity-and-HintsAndSolutionFragment
@rt4914 I have made the suggested changes PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. There is just one issue, if you check the locked item, at the corners you can see white corners. That needs to be fixed.
@rt4914, I have made the necessary change and updated the mocks as well. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
Fixes #4196
Mocks Link:
Hints and solution fragment - https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/12c7159f-4c16-4c89-8311-59963c28c1e4/specs/
https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/c48172a5-8e19-423b-9b57-b57825f0139a/specs/
Story Activity - https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/5abb0ace-19ee-48b8-8154-919154f924d2/specs/
Resume Lesson Activity - https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/1c7d4ec6-a5f1-4462-886d-e47c1457b69e/
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: