Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4346: Remove vacation messaging #4375

Merged
merged 1 commit into from
May 28, 2022
Merged

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented May 28, 2022

Explanation

Fix #4346

Vacation messaging is no longer needed since the review team is back to full capacity.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- This only changes a developer-facing experience on GitHub.

Disable holiday messaging.
@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 23 May 2022.

@BenHenning BenHenning requested a review from seanlip May 28, 2022 00:27
@BenHenning BenHenning enabled auto-merge (squash) May 28, 2022 00:27
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot oppiabot bot unassigned seanlip May 28, 2022
@oppiabot
Copy link

oppiabot bot commented May 28, 2022

Unassigning @seanlip since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented May 28, 2022

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit 699a38b into develop May 28, 2022
@BenHenning BenHenning deleted the disable-holiday-messaging branch May 28, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove reviewer unavailability check after 23 May
2 participants