Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #4195: Added dark mode support to QuestionPlayer and Exploration #4377

Merged
merged 5 commits into from
Jun 1, 2022

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented May 29, 2022

Explanation

Fixes part of #4195 : Added dark mode support to QuestionPlayerActivity and ExplorationActivity

  • This PR focusses on adding dark mode mainly for content part

ScreenShots

Default Dark Mode
Default Dark Mode
Default Dark Mode
Default Dark Mode
Default Dark Mode
Default Dark Mode
Default Dark Mode

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaktideshmukh Suggested changes. Thanks.

app/src/main/res/layout-sw600dp/revision_card_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/content_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/feedback_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/previous_responses_header_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/previous_responses_header_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/revision_card_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/state_fragment.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaktideshmukh Suggested changes. Thanks.

app/src/main/res/layout/previous_responses_header_item.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 May 31, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Jun 1, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 enabled auto-merge (squash) June 1, 2022 14:16
@oppiabot oppiabot bot unassigned rt4914 Jun 1, 2022
@oppiabot
Copy link

oppiabot bot commented Jun 1, 2022

Unassigning @rt4914 since they have already approved the PR.

@rt4914 rt4914 merged commit 107c6ed into oppia:develop Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants