Fixes part of #4178 : Added dark mode support to OnboardingActivity

[bhaktideshmukh]

Explanation

Fixes part of #4178 : Added dark mode support to OnboardingActivity

Mocks link:

• https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/5981ecd6-2a80-4d82-8715-3e92294d53b5/specs/
• https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/69f9affc-7eed-4075-84a5-22d3536c6056/specs/
• https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/9caedbc6-7055-4cff-88e6-caf0052bcf0b/specs/
• https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/7aa006a4-26e4-4525-9609-69795411159a/specs/

Screenshots

Default	Dark mode

Default	Dark mode

Default	Dark mode

Default	Dark mode

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[bhaktideshmukh]

@rt4914
One doubt -- here in slide number 3 link of onboarding, different color is used in mocks for dark mode but in default mode 2 different shades are used for portrait and landscape mode in download sign figure.
So please suggest whether it should be changed or not?

[rt4914]

@bhaktideshmukh I am unable to understand what exactly you mean here?
**different color is used in mocks for dark mode ** -> Can you precise what you are taking about? The background, icon, text, etc?
default mode 2 different shades are used -> What is default mode here? Also what are these two different shades and are they used in? TextView, image or background? Also if possible share links of these two different things that you are talking about.

[bhaktideshmukh]

@bhaktideshmukh I am unable to understand what exactly you mean here? **different color is used in mocks for dark mode ** -> Can you precise what you are taking about? The background, icon, text, etc? default mode 2 different shades are used -> What is default mode here? Also what are these two different shades and are they used in? TextView, image or background? Also if possible share links of these two different things that you are talking about.

Here in ic_portrait_onboarding_2.xml the fillColor used is #00645c where as in ic_landscape_onboarding_2.xml and ic_landscape_onboarding_2_tablet.xml it is #02645c.
And the color used in mocks is #3BD1C4.

[rt4914]

@bhaktideshmukh Do one thing here.

File one detailed issue mentioned this issue and for now use one single color only for dark + light mode which is ic_portrait_onboarding_2.xml.

Once you have filed the issue, mention it here also. And share with me so that I will add more details and then I will share it with design team so that they can clarify things. That way your PR won't get blocked and also it can be a nice goo-first-issue too.

[bhaktideshmukh]

@bhaktideshmukh Do one thing here.

File one detailed issue mentioned this issue and for now use one single color only for dark + light mode which is ic_portrait_onboarding_2.xml.

Once you have filed the issue, mention it here also. And share with me so that I will add more details and then I will share it with design team so that they can clarify things. That way your PR won't get blocked and also it can be a nice goo-first-issue too.

I have filed the issue regarding this and have assigned you as well
#4381
And have changed the fillColor of ic_landscape_onboarding_2.xml and ic_landscape_onboarding_2_tablet.xml to the fillColor of ic_portrait_onboarding_2.xml .

[rt4914]

@bhaktideshmukh Final nit change. Earlier I did suggest these changes but lets first get the confirmation from design team that the images cannot be of different colors.

[oppiabot]

Unassigning @rt4914 since the review is done.

[oppiabot]

Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @rt4914. PTAL. Thanks!

[rt4914]

LGTM, thanks.