Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4169 : Topic name text is cut off in topic_info_fragment for ratios and proportional reasoning #4386

Merged
merged 11 commits into from
Jun 13, 2022
Merged

Fix #4169 : Topic name text is cut off in topic_info_fragment for ratios and proportional reasoning #4386

merged 11 commits into from
Jun 13, 2022

Conversation

MohitGupta121
Copy link
Member

Explanation

Fix #4169 : Topic name text is cut off in topic_info_fragment for ratios and proportional reasoning

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).
Before Screenshots Mobile After Screenshots Mobile
Screenshot_20210804_152357 Screenshot_20210804_152357
Screenshot_20210804_152412 Screenshot_20210804_152412
Screenshot_20210804_152357 Screenshot_20210804_152357
Screenshot_20210804_152412 Screenshot_20210804_152412
Before Screenshots Tablet After Screenshots Tablet
Screenshot_20210804_152357 Screenshot_20210804_152357
Screenshot_20210804_152412 Screenshot_20210804_152412
Screenshot_20210804_152357 Screenshot_20210804_152357
Screenshot_20210804_152412 Screenshot_20210804_152412

@MohitGupta121
Copy link
Member Author

@rt4914 I close the last and open that for the cutoff issue, can you please review that.

@MohitGupta121
Copy link
Member Author

@rt4914 I already add reviewer to you.
Can you please check it's done or not.

@rt4914 rt4914 assigned rt4914 and unassigned MohitGupta121 Jun 12, 2022
@rt4914
Copy link
Contributor

rt4914 commented Jun 12, 2022

@MohitGupta121 You should change the user in "Assignees" section. I just did that. "Assignees" section point to the person who has to take action. For example once I review and suggest changes, I will assign it to you so that you can know that you have to work on it now.

@MohitGupta121
Copy link
Member Author

MohitGupta121 commented Jun 12, 2022

@MohitGupta121 You should change the user in "Assignees" section. I just did that. "Assignees" section point to the person who has to take action. For example once I review and suggest changes, I will assign it to you so that you can know that you have to work on it now.

Okay sure

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit 08d42b5 into oppia:develop Jun 13, 2022
@MohitGupta121
Copy link
Member Author

LGTM, Thanks.

Thanks you 😊

@MohitGupta121 MohitGupta121 deleted the topic-title-cutoff branch December 6, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic name text is cut off in topic_info_fragment for ratios and proportional reasoning
2 participants