Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Part Of #4194: Added dark mode support to DrawerFragment, ConceptCardFragment and AudioFragment #4395

Conversation

Akshatkamboj14
Copy link
Member

Explanation

Fixes Part Of #4194

Drawer Fragment : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/eb119ee3-033f-4757-8aee-7ea234d6f126/specs/

Concept Card Fragment : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/2ee531cf-c358-4a7d-b9dd-b772b51c3d3c/specs/

Audio Fragment : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/d67b268b-f6d9-434f-8897-24a2b13ccd84/specs/

these 2 needs to be done in following PRs.

Revision Card Activity : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/5d907b23-a75e-4f8b-8c59-afd3c734c53e/specs/

Home Activity : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/67bfcbac-7b8e-491b-89c3-38937b37e5c2/specs/

Default Dark Mode
image image
image image
image image
image image
image image

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Akshatkamboj14
Copy link
Member Author

@rt4914 can you PTAL, thanks.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akshatkamboj14 Nice work. Suggested changes.

app/src/main/res/layout/concept_card_fragment.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned Akshatkamboj14 and unassigned rt4914 Jun 30, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 3441214 into oppia:develop Jul 11, 2022
BenHenning added a commit that referenced this pull request Jul 12, 2022
…t, ConceptCardFragment and AudioFragment (#4395)"

This reverts commit 3441214.
This was referenced Jul 12, 2022
@Akshatkamboj14 Akshatkamboj14 self-assigned this Jul 12, 2022
BenHenning added a commit that referenced this pull request Jul 12, 2022
…t, ConceptCardFragment and AudioFragment (#4395)" (#4428)

This reverts commit 3441214.
@bhaktideshmukh
Copy link
Contributor

I'll cover the other two remaining parts -- HomeActivity and RevisionCardActivity in another part of #4194 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants