-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Part Of #4194: Added dark mode support to DrawerFragment, ConceptCardFragment and AudioFragment #4395
Conversation
…CardFragment-and-AudioFragment
@rt4914 can you PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshatkamboj14 Nice work. Suggested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
I'll cover the other two remaining parts -- HomeActivity and RevisionCardActivity in another part of #4194 . |
Explanation
Fixes Part Of #4194
Drawer Fragment : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/eb119ee3-033f-4757-8aee-7ea234d6f126/specs/
Concept Card Fragment : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/2ee531cf-c358-4a7d-b9dd-b772b51c3d3c/specs/
Audio Fragment : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/d67b268b-f6d9-434f-8897-24a2b13ccd84/specs/
these 2 needs to be done in following PRs.
Revision Card Activity : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/5d907b23-a75e-4f8b-8c59-afd3c734c53e/specs/
Home Activity : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/67bfcbac-7b8e-491b-89c3-38937b37e5c2/specs/
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: