-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #426: Topic size fix #440
Conversation
val sizeInGB = size / 1024.0 / 1024.0 / 1024.0 | ||
val sizeInTB = size / 1024.0 / 1024.0 / 1024.0 / 1024.0 | ||
return when { | ||
sizeInTB >= 1 -> decimalFormat.format(sizeInTB) + " TB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's default to KB for now since otherwise we need strings for each of these for localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, then KB will be the only unit for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the conversation, we are keeping this code and we should shift the units to strings.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
LGTM |
Explanation
Check code.
Checklist