Fixes #4340: Introduces Performance Metrics logging #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
requested changes
Sep 16, 2022
There was a problem hiding this comment.
Thanks @Sarthak2601! This is looking really good. Just had a few comments mainly on new code--PTAL.
...src/sharedTest/java/org/oppia/android/app/topic/questionplayer/QuestionPlayerActivityTest.kt
Show resolved
Hide resolved
scripts/src/java/org/oppia/android/scripts/proto/file_content_validation_checks.proto
Outdated
Show resolved
Hide resolved
scripts/src/java/org/oppia/android/scripts/regex/RegexPatternValidationCheck.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/regex/RegexPatternValidationCheckTest.kt
Outdated
Show resolved
Hide resolved
utility/src/test/java/org/oppia/android/util/logging/EventBundleCreatorTest.kt
Outdated
Show resolved
Hide resolved
utility/src/test/java/org/oppia/android/util/logging/EventBundleCreatorTest.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/logging/CurrentAppScreenNameIntentDecorator.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/org/oppia/android/domain/oppialogger/analytics/ActivityLifecycleObserverTest.kt
Outdated
Show resolved
Hide resolved
BenHenning
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Thanks @Sarthak2601! Only have nits left, otherwise the PR LGTM. Feel free to self-resolve the remaining comments once addressed.
scripts/src/javatests/org/oppia/android/scripts/regex/RegexPatternValidationCheckTest.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/regex/RegexPatternValidationCheckTest.kt
Outdated
Show resolved
Hide resolved
scripts/src/javatests/org/oppia/android/scripts/regex/RegexPatternValidationCheckTest.kt
Outdated
Show resolved
Hide resolved
|
Hi @Sarthak2601, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #4340
Introduces performance metrics logging at application startup and via background workers.
Things to note:
I've moved apk size logging and storage usage logging from PerformanceMetricsLogger to the new ActivityLifecycleObserver. This means that the new observer is logging all app startup metrics from one place.
Essential Checklist