Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4491: Update wording for item_selection_text to prevent confusion to students. #4493

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

KevinGitonga
Copy link
Contributor

@KevinGitonga KevinGitonga commented Aug 4, 2022

Fix #4491: This fix updates the wording for "item_selection_text" to "Please select all correct choices" to prevent confusion.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Before Portrait After Portrait
Before Landscape After Landscape

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KevinGitonga! I think this looks good, I just want to verify the testing situation. Also, for your PR please also:

  • Make sure the PR description is formatted similarly to other PRs (I don't think you need a bullet item in this case)
  • Make sure the PR title includes 'Fix' per other PR conventions
  • Make sure the PR checklist is filled out
  • Make sure to add screenshots of any affected Espresso tests still passing

There are also failing CI checks (which might suggest that some tests may need to be updated)--PTAL.

app/src/main/res/values-ar/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Show resolved Hide resolved
@BenHenning BenHenning assigned KevinGitonga and unassigned BenHenning Aug 5, 2022
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KevinGitonga! LGTM.

app/src/main/res/values/strings.xml Show resolved Hide resolved
@BenHenning BenHenning merged commit cec1182 into oppia:develop Aug 17, 2022
@BenHenning BenHenning changed the title Update wording for item_selection_text to prevent confusion to students. Fix #4491: Update wording for item_selection_text to prevent confusion to students. Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ItemSelectionInput instruction to be clearer to students.
2 participants