Fix #425: Update fraction rule parsing to use non-negative int instead of double #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #425.
It seems that we were incorrectly setting 'double' instead of 'nonNegativeInt' for some fractions rules, causing the rules to fail classification during answer submission and more or less break the experience.
This fixes that, but doesn't audit or fix other cases. There are no tests crossing these pipelines yet, and #449 tracks creating these tests.
It may be worth considering always falling back to default when the classification fails, or find another robust way to handle it rather than do nothing.