Fix #4494: Hint bulb animation added #4501
Conversation
|
In this PR Bazel related CI checks are failing which I am unable to solve fully right now.
|
All CI checks are passing now. |
There was a problem hiding this comment.
Thanks @rt4914! The video seems a bit like the animation is intermittent, but it might just be the recording and/or my computer. I'll check it out locally to see how it looks on a device.
app/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
| @@ -338,7 +341,7 @@ class StateFragmentPresenter @Inject constructor( | |||
| oppiaLogger.e("StateFragment", "Failed to retrieve hint/solution", result.error) | |||
| } else { | |||
| // If the hint/solution, was revealed remove dot and radar. | |||
| viewModel.setHintOpenedAndUnRevealedVisibility(false) | |||
| setHintOpenedAndUnRevealed(false) | |||
There was a problem hiding this comment.
Reminders to add tests & add this to questions' implementation, too.
|
Just a note -- agreed with @BenHenning that the pulsing animation looks a bit weird. It looked better in the old video. The behaviour of "flash 5 seconds, stop 25 seconds" seems fine to me though! Thanks Rajat :) |
There was a problem hiding this comment.
Approving this with some open comments. #4510 is tracking addressing those comments post-merge. Plus, an additional review should take place for the changes I contributed directly to the PR (since they haven't yet been reviewed).
Explanation
Fixes #4494
This PR introduces a bouncing animation for the light bulb to make it easier to notice. It has an animation delay of 5 seconds and will repeat every 30 seconds. The animation itself lasts about 6 seconds (see the video below). The animation will continue until the user reveals the hint or moves on to the next card.
Essential Checklist
For UI-specific PRs only
Demonstration video:
hint_bulb_bouncing.mp4