Fix #429: Image left/centre side issue #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@veena14cs Please check whether the True for image in centre |
Okay will check it through. |
rt4914
commented
Nov 20, 2019
rt4914
commented
Nov 20, 2019
rt4914
commented
Nov 20, 2019
| @@ -22,7 +22,7 @@ class HtmlParserTestActivity : InjectableAppCompatActivity() { | |||
| val rawDummyString = | |||
| "\u003cp\u003e\"Let's try one last question,\" said Mr. Baker. \"Here's a pineapple cake cut into pieces.\"\u003c/p\u003e\u003coppia-noninteractive-image alt-with-value=\"\u0026amp;quot;Pineapple cake with 7/9 having cherries.\u0026amp;quot;\" caption-with-value=\"\u0026amp;quot;\u0026amp;quot;\" filepath-with-value=\"\u0026amp;quot;pineapple_cake_height_479_width_480.png\u0026amp;quot;\"\u003e\u003c/oppia-noninteractive-image\u003e\u003cp\u003e\u00a0\u003c/p\u003e\u003cp\u003e\u003cstrong\u003eQuestion 6\u003c/strong\u003e: What fraction of the cake has big red cherries in the pineapple slices?\u003c/p\u003e" | |||
| val htmlResult: Spannable = | |||
| htmlParserFactory.create( /* entityType= */ "exploration", /* entityId= */ "oppia") | |||
| htmlParserFactory.create( /* entityType= */ "exploration", /* entityId= */ "oppia", /* imageCenterAlign= */ false) | |||
There was a problem hiding this comment.
@veena14cs Is this correct?
There was a problem hiding this comment.
it should be true here. As it is checking content.
rt4914
commented
Nov 20, 2019
app/src/main/java/org/oppia/app/topic/overview/TopicOverviewFragmentPresenter.kt
Show resolved
Hide resolved
veena14cs
reviewed
Nov 20, 2019
veena14cs
reviewed
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR makes sure, that images are left in options and centre in content card.
Checklist