-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially Fixes #4194: Added dark mode support to DrawerFragment, ConceptCardFragment and AudioFragment. #4545
Conversation
@Akshatkamboj14 File a separate issue for the view/UI which does not have dark-mode implemented. That way it will be helpful in following cases:
|
Okay sure @rt4914 |
Hey @rt4914 PTAL, Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshatkamboj14 Nice work. One minor change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshatkamboj14 Merge with latest develop.
FYI you might need to remerge as a lot of conflicting PRs are getting merged daily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
Explanation
Partially Fixes #4194
Drawer Fragment: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/eb119ee3-033f-4757-8aee-7ea234d6f126/specs/
Concept Card Fragment: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/2ee531cf-c358-4a7d-b9dd-b772b51c3d3c/specs/
Audio Fragment: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/d67b268b-f6d9-434f-8897-24a2b13ccd84/specs/
-> This PR is Broken into two pieces, First-one is to Add dark mode support to DrawerFragment, ConceptCardFragment, and AudioFragment. The second is to Add dark mode support to HomeActivity and RevisionCardActivity (this is to be done by @bhaktideshmukh)
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: