Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #4194: Added dark mode support to RevisionCardActivity and HomeActivity #4548

Merged

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented Sep 2, 2022

Explanation

This PR covers two parts of #4194 -- RevisionCardActivity and HomeActivity

Mocks link:--

Screenshots

Default Dark mode
Default Dark mode

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaktideshmukh Suggested changes. Also, merge with latest develop.

app/src/main/res/layout/welcome.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Sep 7, 2022
@rt4914
Copy link
Contributor

rt4914 commented Sep 7, 2022

@bhaktideshmukh Also, file a separate issue for Promoted Story Cards- DarkMode so that we can discuss with designers about its design.

@oppiabot
Copy link

oppiabot bot commented Sep 14, 2022

Hi @bhaktideshmukh, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 14, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 19, 2022
@bhaktideshmukh
Copy link
Contributor Author

@bhaktideshmukh Also, file a separate issue for Promoted Story Cards- DarkMode so that we can discuss with designers about its design.

Done.
#4600

@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Sep 21, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 removed their assignment Sep 23, 2022
@rt4914
Copy link
Contributor

rt4914 commented Sep 23, 2022

Stuck on some flaky tests. Restarted

@oppiabot oppiabot bot added the PR: LGTM label Sep 23, 2022
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhaktideshmukh. Took a review pass as well, and didn't spot anything else. Since Rajat already reviewed and his latest comment is addressed (tests are no longer failing in CI), going ahead and merging this.

@BenHenning BenHenning merged commit 69e382b into oppia:develop Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants