-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #4194: Added dark mode support to RevisionCardActivity and HomeActivity #4548
Fixes part of #4194: Added dark mode support to RevisionCardActivity and HomeActivity #4548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhaktideshmukh Suggested changes. Also, merge with latest develop.
@bhaktideshmukh Also, file a separate issue for |
Hi @bhaktideshmukh, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
Stuck on some flaky tests. Restarted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhaktideshmukh. Took a review pass as well, and didn't spot anything else. Since Rajat already reviewed and his latest comment is addressed (tests are no longer failing in CI), going ahead and merging this.
Explanation
This PR covers two parts of #4194 -- RevisionCardActivity and HomeActivity
Mocks link:--
Screenshots
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: