Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #4177: Dark mode Topic Activity Part 1 #4550

Merged
merged 25 commits into from
Sep 7, 2022
Merged

Fixes part of #4177: Dark mode Topic Activity Part 1 #4550

merged 25 commits into from
Sep 7, 2022

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Sep 3, 2022

Explanation

Fixes part of #4177 : Dark mode Topic Activity Part 1 (Toolbar + Tabs)

Dark Mode Mockup:-
https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/3b067181-e5e0-4a5b-bbb8-ab5eda952549/specs/

Default Dark Mode
Screenshot_2022-05-31-12-23-27-332_com android camera

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@MohitGupta121
Copy link
Member Author

@rt4914 can you please review this PR for Part 1 of #4177

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 changed the title Fixed #4177: Dark mode Topic Activity Part 1 Fixes part of #4177: Dark mode Topic Activity Part 1 Sep 7, 2022
@rt4914
Copy link
Contributor

rt4914 commented Sep 7, 2022

@MohitGupta121 In future please make sure you use Fixes part of #xxxx in title and description as you are not finishing the entire issue in this PR. For now I have updated these.

@rt4914 rt4914 merged commit c639763 into oppia:develop Sep 7, 2022
@MohitGupta121
Copy link
Member Author

@MohitGupta121 In future please make sure you use Fixes part of #xxxx in title and description as you are not finishing the entire issue in this PR. For now I have updated these.

Okay thanks you, I take care next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants