Fixed #4409 : Dark Mode support for Confetti

[MohitGupta121]

Explanation

Fixed #4409 : Dark Mode support for Confetti

Default	Dark Mode

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[rt4914]

LGTM, Thanks.

[BenHenning]

Thanks @MohitGupta121! I think this looks really nice! Just had one nit on one of the color's names, otherwise the PR LGTM.

[MohitGupta121]

@BenHenning I commits your suggestion changes. Can you please review it now.

[BenHenning]

Thanks @MohitGupta121! This LGTM. However, please don't resolve reviewers' conversation threads. To indicate something is done, you just need to reply with "Done" and then the reviewer will close the thread once they confirm that it's been addressed as expected (otherwise it's hard to track requested changes across review passes). Note that this is covered in https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR so I suggest taking another pass on that just make sure that you're familiar with the team's PR process. :)

[MohitGupta121]

Oh really sorry actually when I commit new changes it's automatically mark as resolved. As Rajat, in past also told me the same but don't know it's automatically resolved. I take care next time carefully.

[BenHenning]

Oh really sorry actually when I commit new changes it's automatically mark as resolved. As Rajat, in past also told me the same but don't know it's automatically resolved. I take care next time carefully.

Hmm @MohitGupta121 I've never run into this before. Can you reach out to me if you notice again? I don't think GitHub conversation threads are ever supposed to automatically resolve.

[MohitGupta121]

Oh really sorry actually when I commit new changes it's automatically mark as resolved. As Rajat, in past also told me the same but don't know it's automatically resolved. I take care next time carefully.

Hmm @MohitGupta121 I've never run into this before. Can you reach out to me if you notice again? I don't think GitHub conversation threads are ever supposed to automatically resolve.

Sure if I notice it again I let you know about that. But I think I click on the changes suggest and commit from that. Due to this I think that happens as I remember.

[BenHenning]

Ah @MohitGupta121 yes. I forgot about that case. Accepting a suggestion will auto-resolve the conversation thread. I suggest, in those cases, to just reopen the thread and reply to it like you would any other comment.

[MohitGupta121]

Ah @MohitGupta121 yes. I forgot about that case. Accepting a suggestion will auto-resolve the conversation thread. I suggest, in those cases, to just reopen the thread and reply to it like you would any other comment.

oh okay, take care of thread opening next time.