Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #4300: Add strings for beta/GA notices #4566

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Sep 7, 2022

Explanation

Fix part of #4300.

This PR introduces the strings needed in #4417 in isolation so that they can be translated via Translatewiki sooner than #4417 will be merged.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

This PR only introduces strings and otherwise doesn't affect the UI.

@BenHenning
Copy link
Sponsor Member Author

Due to the importance of this getting in (for Beta MR1), force-merging the PR. #4567 is tracking ensuring that this PR is post-merge reviewed.

@BenHenning BenHenning merged commit b1784f0 into develop Sep 7, 2022
@BenHenning BenHenning deleted the add-strings-for-beta-mr1-features branch September 7, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant