Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4445: Add scaling animation for Continue button #4568

Merged
merged 163 commits into from
Nov 19, 2022

Conversation

JishnuGoyal
Copy link
Contributor

@JishnuGoyal JishnuGoyal commented Sep 7, 2022

Explanation

Fixes #4445

This PR is part of the GSoC project: Interactive Onboarding Flow which fixes #4445. It does so by creating a new custom view which connects to the ContinueInteractionItemViewModel, which receives a flag to start animating from the explorationProgressController. We wait for 45 seconds when the first card of a lesson is opened by the user, and then start the animation for the continue button.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Screenrecording_20221118_043637.mp4

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JishnuGoyal. Just had a few follow-up comments, but I think there are still 3 old conversations not yet resolved. Please make sure to resolve these.

Also, CI checks look like they're failing. PTAL.

@BenHenning BenHenning assigned JishnuGoyal and unassigned BenHenning Nov 18, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JishnuGoyal I have checked the implementation and also the code and it does look good for code-owner files.

I have one major suggestion:
The animation for continue button is needed so as to bring users attention to it. So I think some similar thing should be done for non-sighted users too. I was thinking when you start the animation for continue button, at that time the screen-reader can speak some thing which brings users attention like "Navigate and click continue button to visit next screen".

@BenHenning Any thoughts?

@rt4914 rt4914 removed their assignment Nov 18, 2022
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JishnuGoyal! Just one small nit left--PTAL.

@JishnuGoyal I have checked the implementation and also the code and it does look good for code-owner files.

I have one major suggestion: The animation for continue button is needed so as to bring users attention to it. So I think some similar thing should be done for non-sighted users too. I was thinking when you start the animation for continue button, at that time the screen-reader can speak some thing which brings users attention like "Navigate and click continue button to visit next screen".

@BenHenning Any thoughts?

@rt4914 my only concern with this is that it may change the "default ordering" managed by a screenreader. I think your point is definitely valid if we consider this animation essential to progress (since relying on only visual cues isn't a broadly accessible way of doing things). However, perhaps a cleaner way might be to have a better content description for the continue button since it's more likely that a screenreader user will move through the entire view (and thus not miss something). Given this difference in usage, this may be worth exploring in the future if we get feedback that screenreader users are also getting confused sometimes on their first time through the lesson.

@BenHenning BenHenning assigned JishnuGoyal and rt4914 and unassigned BenHenning Nov 18, 2022
…tonView.kt


nit

Co-authored-by: Ben Henning <henning.benmax@gmail.com>
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JishnuGoyal. LGTM.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JishnuGoyal Approving as @BenHenning suggestion does make sense for A11Y. Thanks.

@rt4914 rt4914 removed their assignment Nov 19, 2022
@oppiabot oppiabot bot added the PR: LGTM label Nov 19, 2022
@BenHenning BenHenning enabled auto-merge (squash) November 19, 2022 19:00
@BenHenning BenHenning merged commit 6f26b9e into oppia:develop Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scaling animation for Continue button
3 participants