Fixes part of #4177: Dark mode Topic Activity Part 2 (Info Tab) #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitGupta121
changed the title
|
@rt4914 don't know why these test are failing. I only resolve confilct and update this branch as per Develop. It's buiding succesfull. Also In Test Fail it not specify any particular error. |
rt4914
suggested changes
Sep 12, 2022
| @@ -4,6 +4,6 @@ | |||
| <gradient | |||
| android:angle="270" | |||
| android:startColor="#00FFFFFF" | |||
There was a problem hiding this comment.
Please create a similar value for startColor too
There was a problem hiding this comment.
Please create a similar value for startColor too
Actually startColor not changing in dark_mode it's same. Still I have to make value?
| @@ -246,5 +246,14 @@ | |||
| <color name="component_color_confetti_red_color">@color/color_palette_confetti_red_color</color> | |||
| <color name="component_color_confetti_yellow_color">@color/color_palette_confetti_yellow_color</color> | |||
| <color name="component_color_confetti_blue_color">@color/color_palette_confetti_blue_color</color> | |||
| <!-- Topic Info Activity --> | |||
There was a problem hiding this comment.
Change this to Topic Info Fragment
There was a problem hiding this comment.
Change this to
Topic Info Fragment
okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes part of #4177 : Dark mode Topic Activity Part 2 (Info Tab)
Dark Mode Mockup:-
https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/3b067181-e5e0-4a5b-bbb8-ab5eda952549/specs/
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: