Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #4177: Dark mode Topic Activity Part 3 (Revision Card Tab) #4571

Merged
merged 33 commits into from
Sep 21, 2022
Merged

Fixes part of #4177: Dark mode Topic Activity Part 3 (Revision Card Tab) #4571

merged 33 commits into from
Sep 21, 2022

Conversation

MohitGupta121
Copy link
Member

Explanation

Fixes part of #4177: Dark mode Topic Activity Part 3 (Revision Card Tab)

Dark Mode Mockup:-
https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/1adacef0-f245-4115-a0e0-d1c2e7d5a0bb/specs/

Default Dark Mode
Screenshot_2022-05-31-12-23-27-332_com android camera

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains some unwanted changes in all the files.

Either remove those changes or wait for part-2 to get merged and then merge with develop and update this PR

app/src/main/res/values-night/color_palette.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Sep 12, 2022
@MohitGupta121
Copy link
Member Author

This PR contains some unwanted changes in all the files.

Either remove those changes or wait for part-2 to get merged and then merge with develop and update this PR

Okay understand.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app/src/main/res/values/color_defs.xml Outdated Show resolved Hide resolved
app/src/main/res/values/component_colors.xml Outdated Show resolved Hide resolved
app/src/main/res/values/component_colors.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Sep 19, 2022
@MohitGupta121
Copy link
Member Author

@rt4914 I commit requested changes, can you please review it again.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit 6b58d6a into oppia:develop Sep 21, 2022
@MohitGupta121
Copy link
Member Author

LGTM, Thanks.

Thanks you

@MohitGupta121 MohitGupta121 deleted the dark_mode-TopicActivityPart3 branch December 6, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants