Fixes #4586: Improve text scaling according to accessibility scanner

[vrajdesai78]

Explanation

Fixes #4586: Improved text scaling by setting layout_height and layout_width to wrap_content and setting min_height = 48dp and min_width = 48dp (may vary in some cases).

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

A11YS result before changes

A11Ys result after changes

[vrajdesai78]

@rt4914 Test case is failing because back button and navigation drawer icon is not displayed completely. With the current approach, I am setting minHeight=48dp and layout_height=wrap_content. The problem with this approach is that back button and navigation drawer icon is not set vertically. To set it vertically we need to remove minHeight attribute or need to set minHeight and layout_height same.

[rt4914]

@vrajdesai78 A lot of changes in this PR seems non-required.

For example:

If in current develop code we have attributes

android:layout_height="?attr/actionBarSize"
android:minHeight="?attr/actionBarSize"

than the simplest and most correct solution for that is

android:layout_height="wrap_content"
android:minHeight="?attr/actionBarSize"

Also, I am not getting any error for navigation drawer except for the overall width of the entire navigation drawer, nothing related to icons in toolbar/actionbar.

Please do check app and your changes once again.

Also,

• if anywhere scanner tests are failing, attach screenshot with correct committed code.
• if anywhere UI is not looking good as you mentioned, please share screenshot of that too.

[rt4914]

@vrajdesai78
I haven't tried these solutions but I think this should work

Solution 1

using minWidth="<whatever_the_current_fixed_width_is>"
+
layout_width="wrap_content"
This should mostly solve this error.

Solution 2

Reference

Just a sample code, not perfect, check mocks for perfect code. This sample code is for button.

paddingTop=8dp
paddingBottom=8dp
paddingStart=8dp
paddingEnd=8dp
layout_width="wrap_content"
layout_height="wrap_content"
minHeight=48dp
minWidth=48dp

Solution 3

In this also the layout_height is fixed, simply change that to wrap_content

[rt4914]

@vrajdesai78 Please mention what issues you are still facing in this PR.

Earlier I had a look at PR description from which I understood that you are still stuck on errors but from code it looks like you are not.

So if you are stuck on something explicitly mention that.

Otherwise I have mentioned the approach for buttons, please follow that for better results.

[rt4914]

@vrajdesai78 Requested some explanations. PTAL

[rt4914]

LGTM, Thanks.

[oppiabot]

Unassigning @rt4914 since they have already approved the PR.