Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redundancy for app module ownership #4593

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Sep 13, 2022

Explanation

Updates codeowners for non-XML app module files to ensure there's ownership redundancy (to reduce codereview load on @rt4914 & as part of his transition plan).

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- This is nly changing codeowners.

@BenHenning BenHenning marked this pull request as ready for review September 13, 2022 19:47
@BenHenning BenHenning requested a review from a team as a code owner September 13, 2022 19:47
@BenHenning
Copy link
Sponsor Member Author

@rt4914 @seanlip PTAL.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot @BenHenning

@oppiabot oppiabot bot unassigned rt4914 Sep 13, 2022
@oppiabot
Copy link

oppiabot bot commented Sep 13, 2022

Unassigning @rt4914 since they have already approved the PR.

@seanlip
Copy link
Member

seanlip commented Sep 13, 2022

@BenHenning FYI automated checks are failing.

@seanlip seanlip assigned BenHenning and unassigned seanlip Sep 13, 2022
@oppiabot oppiabot bot added the PR: LGTM label Sep 13, 2022
@oppiabot
Copy link

oppiabot bot commented Sep 13, 2022

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning
Copy link
Sponsor Member Author

Thanks both!

@BenHenning BenHenning enabled auto-merge (squash) September 14, 2022 03:56
@BenHenning BenHenning merged commit 69c914f into develop Sep 14, 2022
@BenHenning BenHenning deleted the update-codeowners-app-module-ownership branch September 14, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants