Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4086: Changed the revision tab icon. #4635

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

pratyaksh1610
Copy link
Contributor

Explanation

Fix #4086
Changed the revision tab icon.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Before

WhatsApp Image 2022-10-01 at 2 32 15 PM

WhatsApp Image 2022-10-01 at 2 32 14 PM (1)

After

WhatsApp Image 2022-10-01 at 2 32 13 PM

WhatsApp Image 2022-10-01 at 2 32 14 PM

@pratyaksh1610
Copy link
Contributor Author

PTAL @BenHenning

@BenHenning
Copy link
Sponsor Member

Sorry, will need to look at this tomorrow.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pratyaksh1610. I've left some follow-up comments--PTAL.

app/src/main/res/drawable/_revision.xml Outdated Show resolved Hide resolved
app/src/main/res/drawable/_revision.xml Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/topic/TopicTab.kt Outdated Show resolved Hide resolved
@pratyaksh1610
Copy link
Contributor Author

I have made the change

@pratyaksh1610
Copy link
Contributor Author

PTAL @BenHenning

@oppiabot oppiabot bot assigned BenHenning and unassigned pratyaksh1610 Oct 5, 2022
@oppiabot
Copy link

oppiabot bot commented Oct 5, 2022

Unassigning @pratyaksh1610 since a re-review was requested. @pratyaksh1610, please make sure you have addressed all review comments. Thanks!

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pratyaksh1610. This looks good to me.

However, please make sure to reply to all comments when you've addressed them, otherwise it's difficult for your reviewers to know what to check.

@BenHenning BenHenning merged commit 8892584 into oppia:develop Oct 6, 2022
@pratyaksh1610 pratyaksh1610 deleted the revision-icon-branch branch October 6, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Revision Tab Icon
2 participants