Fix #3746: Add regex to ban <include> tag in layout files.

[Ryggs]

Explanation

Fixes #3746

This PR bans all usage of the <include...> tag in XML layout files that reference it. It does so by adding a check block inside the file_content_validation_checks text proto script file.

This pr also removes the toolbar.xml file, since its no longer being used.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

SCREENSHOT FOR THE REGEX PATTERN CHECKS FAILED

SCREENSHOT FOR THE REGEX PATTERN CHECKS PASSED

A LIST OF THE FILES THAT HAVE THE <INCLUDE.../> TAG

• app/src/main/res/layout/add_profile_activity.xml
• addprofileactivity
• app/src/main/res/layout/administrator_controls_activity.xml:15: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout/help_without_drawer_activity.xml:11: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout/option_activity.xml:13: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout/options_without_drawer_activity.xml:11: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout/developer_options_activity.xml:15: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout/home_activity.xml:14: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout/help_activity.xml:13: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout/profile_progress_activity.xml:9: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout-sw600dp/administrator_controls_activity.xml:15: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout-sw600dp/option_activity.xml:13: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout-sw600dp/options_without_drawer_activity.xml:12: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead
• app/src/main/res/layout-sw600dp/help_activity.xml:13: Remove <include .../> tag from layout and use the appropriate widget, e.g like AppBarLayout widget instead

[BenHenning]

Thanks @Ryggs! Took a first pass. This looks on the correct track. I did have some follow-up comments--PTAL.

[BenHenning]

@Ryggs I think there's still an issue here--PTAL at my comment.

[BenHenning]

@Ryggs PTAL at https://github.com/oppia/oppia-android/pull/4656/files#r1012488357.

[BenHenning]

Thanks @Ryggs. The PR LGTM, but please update to the latest develop & send back so that I can approve & merge.

[BenHenning]

Actually, maybe I can just update the branch to avoid needing to do another back-and-forth.

[BenHenning]

Given the clean sync with develop, approving this and enabling auto-merge.

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.