Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hifi improvised topic #466

Merged
merged 8 commits into from
Nov 25, 2019
Merged

Hifi improvised topic #466

merged 8 commits into from
Nov 25, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 21, 2019

Explanation

This PR is basically solving all margin/padding related issues.

Issues Document Link: https://docs.google.com/document/d/1VJQa91i5Eq5xCe7KKZoT7d8HAWOjE50hvhs54F8_e7s/edit?usp=sharing

Mock Link:https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/19cfbacf-854c-4c7d-8691-3b3d117e1866/TP-Overview-

Screenshots

Screenshot_1574326010
Screenshot_1574328641
Screenshot_1574328645
Screenshot_1574330171
Screenshot_1574330176
Screenshot_1574332364
Screenshot_1574333043

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the title Hifi final topic Hifi improvised topic Nov 21, 2019
android:layout_marginStart="40dp"
android:layout_marginTop="20dp"
android:layout_marginEnd="20dp"
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is issue over here if we have more items in the list. I think we should remove padding bottom from LinearLayout. And As Recyclerview is inside scrollview, scrolling is giving problem when list is big. Please check

untitled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as this PR is mostly on on Hifi, I will be creating a separate PR for this issue.
I have filed a issue to solve this. #468
So I believe this PR can be merged and this issue will get solved in #468

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address one issue with scrolling in train tab.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Nov 21, 2019
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 21, 2019

Please address one issue with scrolling in train tab.

I think we will need to change the implementation of recyclerview in this, we will have to create this in a similar that we created other recyclerviews like HomeFragment and StateFragment.

@veena14cs
Copy link
Contributor

Please address one issue with scrolling in train tab.

I think we will need to change the implementation of recyclerview in this, we will have to create this in a similar that we created other recyclerviews like HomeFragment and StateFragment.

Ok rest all things looks good.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Nov 22, 2019
@rt4914 rt4914 merged commit c948e7a into develop Nov 25, 2019
@rt4914 rt4914 deleted the hifi-final-topic branch November 25, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants