-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hifi improvised topic #466
Conversation
android:layout_marginStart="40dp" | ||
android:layout_marginTop="20dp" | ||
android:layout_marginEnd="20dp" | ||
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address one issue with scrolling in train tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we will need to change the implementation of recyclerview in this, we will have to create this in a similar that we created other recyclerviews like HomeFragment and StateFragment. |
Ok rest all things looks good. |
Explanation
This PR is basically solving all margin/padding related issues.
Issues Document Link: https://docs.google.com/document/d/1VJQa91i5Eq5xCe7KKZoT7d8HAWOjE50hvhs54F8_e7s/edit?usp=sharing
Mock Link:https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/19cfbacf-854c-4c7d-8691-3b3d117e1866/TP-Overview-
Screenshots
Checklist