Fixes #3432: Use alt-with-value from <oppia-noninteractive-image> in RichText

[vrajdesai78]

Explanation

Fixes #3432: Created a handleContentDescription function in CustomHtmlContentHandler which is further override in ImageTagHandler. With current approach, I am setting up text (content description text from alt-with-value) to image.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

Demo Video

rich-text.mp4

[BenHenning]

As discussed, this requires further debugging by you, correct @vrajdesai78? Sending it back to you until the solution is fully working.

Also, should this be marked as a draft since it's not yet finished?

[vrajdesai78]

As discussed, this requires further debugging by you, correct @vrajdesai78? Sending it back to you until the solution is fully working.

Also, should this be marked as a draft since it's not yet finished?

Yes we can mark it as draft PR

[rt4914]

Not sure why its working when the app is coming from background but maybe log all the important information which is responsible for displaying the item-selection-interaction and from that first try to understand what is different.

For example,
when we are changing the state, ie. going from one-question to another, activity/fragment lifecycle is not shifting to other methods like onResume, onCreate, onPause, onStop, onStart`, etc. but when app is in background and is again in foreground these methods are called and maybe there is some code in these methods which is fixing the issue.

[vrajdesai78]

Not sure why its working when the app is coming from background but maybe log all the important information which is responsible for displaying the item-selection-interaction and from that first try to understand what is different.

For example, when we are changing the state, ie. going from one-question to another, activity/fragment lifecycle is not shifting to other methods like onResume, onCreate, onPause, onStop, onStart`, etc. but when app is in background and is again in foreground these methods are called and maybe there is some code in these methods which is fixing the issue.

@rt4914 I have tried to investigate lifecycle methods like onResume and onStop which are getting called when we keep our app in background and again in foreground. Suprisingly, I haven't found any such method's overriding (onResume, onStop and onPause) in our current codebase. Can you help suggest me some next steps how can I investigate this issue.

[vrajdesai78]

@BenHenning can you PTAL. I have solve the issue of loading images in SelectionInteractionView. Actually, there we were calling View.width { ... } which is creating the problem, so now I am calculating the width directly by calling View.width. Also, update the video in the description with the latest code changes.

[rt4914]

@vrajdesai78 LGTM, Just check ben's comment, in that PR I have mentioned how to test that bug so please follow those steps and create a video too displaying that the current change does not re-surface that issue.

[vrajdesai78]

@BenHenning can you PTAL. I have replied to all of your comments and also mentioned why this solution works. Thanks

[BenHenning]

Thanks @vrajdesai78. Just a bit of work needed left on the UrlImageParser comment, but otherwise the PR LGTM.

[BenHenning]

Thanks @vrajdesai78 just had a few nits--PTAL.

[BenHenning]

Thanks @vrajdesai78--the PR LGTM. Also, please make sure not to resolve revewiers' comments (since it makes it easier to then lose these comments).

[vrajdesai78]

Thanks @vrajdesai78 just had a few nits--PTAL.

@BenHenning fixed nit changes

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot]

Unassigning @vrajdesai78 since a re-review was requested. @vrajdesai78, please make sure you have addressed all review comments. Thanks!

[vrajdesai78]

@BenHenning @rt4914 can you re-run CI checks, it failed due to connection timed out