Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RunAllTests] Fix #4512: Upgrade CI to Ubuntu 20.04 #4677

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Oct 28, 2022

Explanation

Fixes #4512

Per actions/runner-images#6002 this migrates all CI actions over to Ubuntu 20.04 since 18.04 has been deprecated and is being phased out of production.

Due to limited time, I'm planning to fast-track this PR by merging it if CI passes for all tests.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- This only affects the CI runtime environment, not the app or anything user-facing.

@BenHenning BenHenning marked this pull request as ready for review October 28, 2022 08:03
@BenHenning
Copy link
Sponsor Member Author

@seanlip PTAL or delegate. Note that I'll update the required workflows once this is ready to get merged since I'll need to send out a mail to the developer list given this will break all in-flight PRs and lead to a required re-sync.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanlip
Copy link
Member

seanlip commented Oct 28, 2022

(Feel free to update the required workflows.)

@seanlip seanlip assigned BenHenning and unassigned seanlip Oct 28, 2022
@oppiabot oppiabot bot added the PR: LGTM label Oct 28, 2022
@oppiabot
Copy link

oppiabot bot commented Oct 28, 2022

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit 724fcb6 into develop Oct 29, 2022
@BenHenning BenHenning deleted the update-runner-ubuntu-versions branch October 29, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade CI to Ubuntu 20.04
2 participants