Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part #22: Navigation drawer part 1 #470

Merged
merged 18 commits into from
Nov 28, 2019
Merged

Fix part #22: Navigation drawer part 1 #470

merged 18 commits into from
Nov 28, 2019

Conversation

nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt commented Nov 22, 2019 •
edited

Explanation

duplicate of #84
xml files in Navigation drawer
as per design document
https://docs.google.com/document/d/1Q9957ri3TlsTWdwBVAjn4g9EJzqmzBqrSXCHI3yRTEE/edit?usp=sharing

Mock

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/346dd03d-464b-4b49-9d7f-7ec6264fefd6/TP-Play-Side-Menu-1

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@nikitamarysolomanpvt nikitamarysolomanpvt requested review from veena14cs, BenHenning and rt4914 and removed request for BenHenning November 22, 2019 10:38
rt4914
rt4914 suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting this error on Google Pixel 3 (Real device) and Galaxy Nexus (Emulator).
Screenshot 2019-11-25 at 10 34 49 AM

app/src/main/res/drawable/ic_admin_settings_icon_grey_24dp.xml Outdated Show resolved Hide resolved
app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
jamesxu0
jamesxu0 reviewed Nov 25, 2019
View reviewed changes
.idea/gradle.xml Outdated Show resolved Hide resolved
@jamesxu0 jamesxu0 removed their assignment Nov 25, 2019
@nikitamarysolomanpvt
Copy link
Contributor Author

I am getting this error on Google Pixel 3 (Real device) and Galaxy Nexus (Emulator).
Screenshot 2019-11-25 at 10 34 49 AM

Reverted home_activity.xml . Would add it in next PR as it is having dependency.

veena14cs
veena14cs suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the changes and assign me back.

rt4914
rt4914 suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

app/src/main/res/anim/slide_out_left.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_drawer.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_drawer.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_drawer.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_drawer.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/help_activity.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/help_activity.xml Outdated
android:id="@+id/container_body"
android:layout_width="match_parent"
android:layout_height="0dp"
android:layout_weight="1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this and suggest using match_parent in layout_height

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed help_activity.xml due to dependency.

app/src/main/res/menu/navigation_drawer_menu.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Nov 25, 2019
rt4914
rt4914 approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 removed their assignment Nov 28, 2019
veena14cs
veena14cs approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one nit change.

@veena14cs veena14cs removed their assignment Nov 28, 2019
@nikitamarysolomanpvt nikitamarysolomanpvt merged commit 613e133 into develop Nov 28, 2019
@nikitamarysolomanpvt nikitamarysolomanpvt deleted the navigation-drawer-part-1 branch November 28, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschanteltc mschanteltc mschanteltc left review comments

@jamesxu0 jamesxu0 jamesxu0 left review comments

@rt4914 rt4914 rt4914 approved these changes

@veena14cs veena14cs veena14cs approved these changes

Assignees

@jamesxu0 jamesxu0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nikitamarysolomanpvt @rt4914 @veena14cs @mschanteltc @jamesxu0