Fixes #4701: Improve accessibility for confetti text #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s://github.com/vrajdesai78/oppia-android into Improve-accessibility-for-congratulations-text
rt4914
suggested changes
Nov 8, 2022
There was a problem hiding this comment.
@vrajdesai78 Firstly you cannot directly use component_color_shared_progress_bar_stroke_color, its not a progress bar its a congratulations text view.
So you will need to update value of component_color_shared_correct_text_color in colors file.
Secondly, please share before and after screenshot side-by-side to clearly show the difference.
app/src/main/res/layout-sw600dp-land/question_player_fragment.xml
Outdated
Show resolved
Hide resolved
app/src/main/res/layout-sw600dp-port/question_player_fragment.xml
Outdated
Show resolved
Hide resolved
adhiamboperes
pushed a commit
to adhiamboperes/oppia-android
that referenced
this pull request
Nov 10, 2022
## Explanation Fixes oppia#4701: Improved accessibility for congratulations text by changing height to wrap_content and improved contrast ratio by changing color in color pallet. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## Screenshot Before | After :-------------------------:|:-------------------------:  | 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #4701: Improved accessibility for congratulations text by changing height to wrap_content and improved contrast ratio by changing color in color pallet.
Essential Checklist
Screenshot