Fix #4709: Revert "Fix #2581: Marquee auto restart issue (#4392)" #4730
Conversation
|
Note that I've just self-reviewed this PR to make sure it all makes sense. There are only a few major differences in the layout structure, and I've manually verified that the marquee behaviors seem correct for all affected screens (plus, it's reverting back to a state that has been used for years prior in the app). |
|
/cc @KevinGitonga as well as an FYI. Unfortunately, we need to revert your marquee view PR since I don't think we're going to be able to make it work (see #4709 (comment) for more specifics). I'll reopen #2581 once this is merged and then close it as infeasible. |
BenHenning
added
the
PR: Cherrypick requested
|
@seanlip PTAL. Note that I'll make the one edit I mentioned in my comment above & update to the latest develop a bit later since both are innocuous and unlikely to cause issues. |
|
Assigning @rt4914 for code owner reviews. Thanks! |
Revert style-only change.
|
Going ahead and merging this without your review @rt4914 since it's mainly a reversion, and it's release blocking. Feel free to post-submit review if you think you should. |
) ## Explanation Fixes #4709 This reverts commit 846657e from PR #4392. See #4709 (comment) for a detailed explanation for why this reversion is the correct approach. Note that this PR will be cherry-picked into the 0.10 release branch for the upcoming MR2 beta release. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only This is a mostly clean reversion of #4392, so see that PR for an idea on how marquees behaved prior to that PR (as this PR returns the app to that behavior).
BenHenning
added
the
PR: Cherrypick completed
Explanation
Fixes #4709
This reverts commit 846657e from PR #4392. See #4709 (comment) for a detailed explanation for why this reversion is the correct approach.
Note that this PR will be cherry-picked into the 0.10 release branch for the upcoming MR2 beta release.
Essential Checklist
For UI-specific PRs only
This is a mostly clean reversion of #4392, so see that PR for an idea on how marquees behaved prior to that PR (as this PR returns the app to that behavior).