Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version codes to prepare for RC02 of Beta MR2 #4745

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Nov 18, 2022

Explanation

Updates version codes for RC02 of Beta MR2 (since cherry-picks were needed).

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- This is an infrastructural change that doesn't affect the user experience.

Update version codes for Beta MR2 RC02.
@BenHenning BenHenning marked this pull request as ready for review November 18, 2022 10:54
@BenHenning
Copy link
Sponsor Member Author

Note that I will be force merging this since folks who have write access are probably not available right now. It's a simple enough change that I'm comfortable doing so, and I'll make sure it gets post-submit reviewed.

@BenHenning BenHenning added PR: Cherrypick requested Indicates that a PR is being requested for being cherrypicked into the ongoing release branch. TODO: Review (post-merge) labels Nov 18, 2022
@BenHenning
Copy link
Sponsor Member Author

Merging since CI checks are passing.

@BenHenning BenHenning merged commit e7d308a into develop Nov 18, 2022
@BenHenning BenHenning deleted the update-beta-version-codes-for-rc02 branch November 18, 2022 11:51
BenHenning added a commit that referenced this pull request Nov 18, 2022
## Explanation
Updates version codes for RC02 of Beta MR2 (since cherry-picks were
needed).

## Essential Checklist
- [ ] ~The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)~
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [ ] ~The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).~

## For UI-specific PRs only
N/A -- This is an infrastructural change that doesn't affect the user
experience.
@BenHenning BenHenning added the PR: Cherrypick completed Indicates a cherrypick request was approved & completed for a PR. label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Cherrypick completed Indicates a cherrypick request was approved & completed for a PR. PR: Cherrypick requested Indicates that a PR is being requested for being cherrypicked into the ongoing release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant