Fix #4722: Created date not fully visible for certain devices and languages

[antonmagnus]

Explanation

Fixes issue #4772

This PR adds some margin to the end of the created date text on the edit profile view to make sure that it's fully visible.

The main development was done on a pixel 3a on API 29 (see the screenshots below). However, since the issue was reported on a Infinix SMART 5 the changes have also been tested on a device with a similar screen resolution (Galaxy Nexus on API 29).

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Previous version

New version

ProfileEditFragmentTest

[BenHenning]

@antonmagnus could you please update the PR description to match the PR template, and make sure that each section is filled out?

[antonmagnus]

@antonmagnus could you please update the PR description to match the PR template, and make sure that each section is filled out?

Updated and included the template checklist.

[BenHenning]

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?

See #4685 for an example PR description.

[oppiabot]

Hi @antonmagnus, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[antonmagnus]

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?

See #4685 for an example PR description.

I have now updated the description in accordance with the template. Do you have any further suggestions?

[BenHenning]

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?
See #4685 for an example PR description.

I have now updated the description in accordance with the template. Do you have any further suggestions?

I think it's much better, but I suggest a few small changes to help with readability (& to ensure GitHub correctly closes the corresponding issue once this is closed):

Fixes issue #4772

This PR adds some margin to the end of the created date text on edit profile view to make sure that it's fully visible.

The main development was done on a pixel 3a on API 29 (see the screenshots below). However, since the issue was reported on a Infinix SMART 5 the changes have also been tested on a device with similar screen resolution (Galaxy Nexus on API 29).

Notice how I formatted the 'fixes' part, and also re-worded the explanation to read more as "Did X to fix Y" to be really clear on what the PR is doing.

[antonmagnus]

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?
See #4685 for an example PR description.

I have now updated the description in accordance with the template. Do you have any further suggestions?

I think it's much better, but I suggest a few small changes to help with readability (& to ensure GitHub correctly closes the corresponding issue once this is closed):

Fixes issue #4772

This PR adds some margin to the end of the created date text on edit profile view to make sure that it's fully visible.

The main development was done on a pixel 3a on API 29 (see the screenshots below). However, since the issue was reported on a Infinix SMART 5 the changes have also been tested on a device with similar screen resolution (Galaxy Nexus on API 29).

Notice how I formatted the 'fixes' part, and also re-worded the explanation to read more as "Did X to fix Y" to be really clear on what the PR is doing.

Thank you for the suggestions, I agree that it is clearer now.
I have updated the description based on your suggestions.

[BenHenning]

Thanks @antonmagnus. Note that, when you're done addressing a reviewer's comments, you should let them know by saying 'PTAL @' so that they are aware that they need to take another review pass.

@rt4914 PTAL for codeowners.

[rt4914]

LGTM, Thanks @antonmagnus

[oppiabot]

Hi @antonmagnus, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[oppiabot]

Hi @antonmagnus, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[BenHenning]

Resolving the conflict & marking this PR for auto-merge since it's been approved.