Fix #4764: Spotlight overlays have some UI issues

[JishnuGoyal]

Explanation

fixes #4764
Updated video demo:

spotlightdemo.mp4

Updated screenshots:

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Portrait

Land:

mobile rtl:

Tablet:

Video (spotlight experience):

WhatsApp.Video.2022-11-25.at.10.58.53.PM.mp4

Video (Talkback):

WhatsApp.Video.2022-11-25.at.11.02.41.PM.mp4

[JishnuGoyal]

Update: All done.

tasks left: Add screenshots and videos demonstrating the behaviour and UI of the spotlights introduced.

[BenHenning]

Thanks @JishnuGoyal! I think it looks much better! I have a few comments, but besides that the alignment of text looks a bit off, ditto for the new x button: can we keep the top of the x button aligned with the text? Also, the text top and bottom margins relative to the background should always be the same (sometimes it seems like one is larger than the other in your pictures).

[oppiabot]

Unassigning @BenHenning since the review is done.

[oppiabot]

Hi @JishnuGoyal, it looks like some changes were requested on this pull request by @BenHenning. PTAL. Thanks!

[rt4914]

Awesome work @JishnuGoyal Thanks.

[JishnuGoyal]

Thanks! @rt4914 and @BenHenning. FYI i have updated the UI as requested and addressed the review comments. This PR is getting a bit time sensitive so i have updated everything to the best of my knowledge. PTAL.

[rt4914]

#4763 (comment)
-> Don't have much context about it so haven't been able to help to resolve the comment.

#4763 (comment)
-> LGTM from my side.

[BenHenning]

Thanks @JishnuGoyal. Just two follow-ups--PTAL. Otherwise, the PR LGTM.

[BenHenning]

Thanks, LGTM!

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.