Fixes #4738, #4381, #4734: Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin

[rt4914]

Explanation

Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin

Fixes #4738 - Some views have very low visibility on add user profile screen in dark mode [A11y]
Fixes #4381 : Different shades of fillColor used in portrait and landscape of ic_onboarding_2.xml
Fixes #4734 : Contrast issue in show/hide password icon

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Onboarding Screen

Profile Chooser (Same for dark mode and light mode)

Add Admin Pin

Admin Auth

Pin Password

Add Profile

Tablet Design Recording

device-2022-12-08-183826.webm

[MohitGupta121]

@rt4914 I think this PR fixed the issues #4738, #4381, #4734

[oppiabot]

Hi @rt4914, it looks like some changes were requested on this pull request by @MohitGupta121. PTAL. Thanks!

[MohitGupta121]

@rt4914 PTAL. I have one doubt.

[rt4914]

Onboarding icon color update

[MohitGupta121]

LGTM, Thanks.

[oppiabot]

Assigning @seanlip, @BenHenning for code owner reviews. Thanks!

[rt4914]

Hi @BenHenning @seanlip One of you will need to approve this PR. @BenHenning Feel free to review it. (FYI: Naming of some things might be a bit off right now)

[seanlip]

Thanks @rt4914, this looks great! LGTM.