Fixes #4624, #4741, #4461 : Dark mode implementation - Topic Lessons, Topic Revision, Revision Card, Story Activity, Resume Lesson #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rt4914 I added changes as per your review. |
rt4914
suggested changes
Dec 28, 2022
|
@rt4914 update the changes as per review and screenshots. |
rt4914
approved these changes
Dec 28, 2022
Closed
Closed
seanlip
pushed a commit
that referenced
this pull request
Jul 14, 2023
…ext, and change button name"" (#5090) Fixes #5088. Reverts #4987 which removed styles and added changes that broke the dark mode support previously correctly implmented in #4796. This is a clean revert so it can be merged directly. | Before - Light Mode | Before - Dark Mode | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/8494dcd1-c8cf-441a-9cea-305cc1afdb1e" height="400" style="max-width: 100%"> | <img src="https://github.com/oppia/oppia-android/assets/76530270/e823a67e-3eb2-4f4d-86c1-7bbcb4bd4380" height="400" style="max-width: 100%"> | | After - Light Mode | After - Dark Mode | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/9651500d-3434-4d44-b2b4-9ea3b28c072b" height="400" style="max-width: 100%"> | <img src="https://github.com/oppia/oppia-android/assets/76530270/bba4d86f-2ea8-4401-9e81-6d8d3318ac5f" height="400" style="max-width: 100%"> | | Before - Dark Mode Landscape | After - Dark Mode Landscape | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/36d3fb9d-3388-4c78-ba57-c932f360a7b0" > | <img src="https://github.com/oppia/oppia-android/assets/76530270/143434c9-6288-4d44-8390-c4d55f28fc40"> | | Before - Dark Mode Tab | After - Dark Mode Tab | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/a4155c3f-ec4e-4b82-b113-eb7739af70e5" > | <img src="https://github.com/oppia/oppia-android/assets/76530270/ff604777-1581-41b7-b738-337814c9ac73" > |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Dark mode implementation - Topic Lessons, Topic Revision, Revision Card, Story Activity, Resume Lesson
Fixes #4624 : Add dark mode support to Lesson Tab
Fixes #4741 : Contrast issue in Continue Studying text on revision screen
Fixes #4461 : TextView & Toolbar color changes in Topic screen
Essential Checklist
For UI-specific PRs only
Topic Lessons
Topic Revision
Revision Card
Story Activity
Resume Lesson
If your PR includes UI-related changes, then: