Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build artifact workflows & repository messaging #4797

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

BenHenning
Copy link
Sponsor Member

@BenHenning BenHenning commented Dec 21, 2022

Explanation

This PR does two things:

  • It updates repository messaging to indicate multiple team members may be unavailable until early January (which will show on all new/reopened PRs once this is merged). I'll update existing PRs so that authors are aware.
  • It updates the build tests CI workflow to only upload the Oppia dev APK (as this is the only one practically useful for developers since the AABs can't be directly installed on a device).

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- Infrastructure-only change.

@BenHenning
Copy link
Sponsor Member Author

Changes to the build_tests check can be seen here: https://github.com/oppia/oppia-android/actions/runs/3746263462 in the artifacts list (it's only uploading the one APK now).

Note that the repository messaging can't be tested until after the PR is merged, but I had a PR recently close so I'll reopen that to verify that it's working.

Finally, the failing CI check is just a flake that I'll re-run.

@BenHenning BenHenning marked this pull request as ready for review December 21, 2022 04:17
@BenHenning
Copy link
Sponsor Member Author

@seanlip PTAL.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@oppiabot oppiabot bot unassigned seanlip Dec 21, 2022
@oppiabot
Copy link

oppiabot bot commented Dec 21, 2022

Unassigning @seanlip since they have already approved the PR.

@BenHenning BenHenning enabled auto-merge (squash) December 21, 2022 19:32
@BenHenning BenHenning merged commit b7f0588 into develop Dec 21, 2022
@BenHenning BenHenning deleted the update-workflows branch December 21, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants