-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #362: Add congratulations message when a correct answer is submitted #480
Conversation
@BenHenning to identify correct answer is submitted , we are using |
@veena14cs Please mention those explorations too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veena14cs The text is visible behind state buttons. I think to solve this you will need to make the elevation of textview to be around 6-8dp. You might need to introduce CardView also.
The gif looks awesome--nice! |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…a/oppia-android into hifi-congratulation-message
I fixed this by giving elevation to framelayout. I have not used cardview. PTAL once. |
For Prototype Exploration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Its great.
@veena14cs Do not delete this branch. Needs this to track another issue. |
This animation looks great and would be suitable if the app is on battery saving mode. When it's not on battery saving mode, can we animate it so that the "Correct" toaster rises, then fades down? It would use an "Ease-In-Out" animation going up with a duration of 0.4 s. The correct toaster will stay for 3s. After it would fade and move down also with an Ease-In-Out animation with a duration of 0.4 s. The beginning and ending state of the "Correct" toaster is 20 px below the middle state where the toaster stays in place. |
Explanation
This PR shows congratulation message when correct answer is submitted. This message has got fading animation
Mocks
https://xd.adobe.com/spec/bee1fced-33bd-4f69-6a89-2c30fe1c4f65-c8d0/screen/cf6a4999-56aa-4c3c-802f-7573a0457f9b/PM-Q1-Fraction-Input-Correct-Toaster-.
Screenshot