Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #362: Add congratulations message when a correct answer is submitted #480

Merged
merged 12 commits into from
Nov 28, 2019

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Nov 27, 2019

Explanation

This PR shows congratulation message when correct answer is submitted. This message has got fading animation

Mocks

https://xd.adobe.com/spec/bee1fced-33bd-4f69-6a89-2c30fe1c4f65-c8d0/screen/cf6a4999-56aa-4c3c-802f-7573a0457f9b/PM-Q1-Fraction-Input-Correct-Toaster-.

Screenshot

un

@veena14cs
Copy link
Contributor Author

veena14cs commented Nov 27, 2019

@BenHenning to identify correct answer is submitted , we are using result.labelledAsCorrectAnswer.
But this is not working on some explorations.

@rt4914
Copy link
Contributor

rt4914 commented Nov 27, 2019

@BenHenning to identify correct answer is submitted , we are using result.labelledAsCorrectAnswer.
But this is not working on some explorations.

@veena14cs Please mention those explorations too.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veena14cs The text is visible behind state buttons. I think to solve this you will need to make the elevation of textview to be around 6-8dp. You might need to introduce CardView also.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 and BenHenning Nov 27, 2019
@BenHenning
Copy link
Sponsor Member

The gif looks awesome--nice!

@veena14cs
Copy link
Contributor Author

The gif looks awesome--nice!

Thanks!

Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Nov 28, 2019
@veena14cs
Copy link
Contributor Author

@veena14cs The text is visible behind state buttons. I think to solve this you will need to make the elevation of textview to be around 6-8dp. You might need to introduce CardView also.

I fixed this by giving elevation to framelayout. I have not used cardview. PTAL once.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Nov 28, 2019
@veena14cs
Copy link
Contributor Author

@BenHenning to identify correct answer is submitted , we are using result.labelledAsCorrectAnswer.
But this is not working on some explorations.

@veena14cs Please mention those explorations too.

For Prototype Exploration result.labelledAsCorrectAnswer is not working.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Its great.

@rt4914
Copy link
Contributor

rt4914 commented Nov 28, 2019

@veena14cs Do not delete this branch. Needs this to track another issue.

@veena14cs veena14cs merged commit 8f3d084 into develop Nov 28, 2019
@mschanteltc
Copy link

This animation looks great and would be suitable if the app is on battery saving mode.

When it's not on battery saving mode, can we animate it so that the "Correct" toaster rises, then fades down? It would use an "Ease-In-Out" animation going up with a duration of 0.4 s. The correct toaster will stay for 3s. After it would fade and move down also with an Ease-In-Out animation with a duration of 0.4 s. The beginning and ending state of the "Correct" toaster is 20 px below the middle state where the toaster stays in place.

@BenHenning BenHenning deleted the hifi-congratulation-message branch June 10, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants