Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Part of #4195 : Dark mode implementation - Buttons and Input Interaction items of Questions and Exploration #4825

Merged
merged 74 commits into from
Jan 9, 2023
Merged

Fixes Part of #4195 : Dark mode implementation - Buttons and Input Interaction items of Questions and Exploration #4825

merged 74 commits into from
Jan 9, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Jan 7, 2023

Explanation

Fixes Part of #4195 : Dark mode implementation - Buttons and Input Interaction items of Questions and Exploration

Files I have Checked & Changed:-

styles.xml

previous_next_state_image_view_background.xml
state_button_primary_background.xml
continue_navigation_button_item.xml
next_button_item.xml
previous_button_item.xml
replay_button_item.xml
return_to_lesson_button_item.xml
return_to_topic_button_item.xml
submit_button_item.xml

color_cursor.xml
edit_text_background.xml

ratio_input_interaction_item.xml
text_input_interaction_item.xml
numeric_input_interaction_item.xml

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Buttons and Input Interactions

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL, can you please review this PR.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit 13b07e7 into oppia:develop Jan 9, 2023
@MohitGupta121 MohitGupta121 deleted the dark-mode-buttons-input-interaction-items branch January 9, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants