Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Part of #4195 : Dark mode implementation - Different Interactions items of Questions and Exploration #4828

Merged
merged 83 commits into from
Jan 12, 2023
Merged

Fixes Part of #4195 : Dark mode implementation - Different Interactions items of Questions and Exploration #4828

merged 83 commits into from
Jan 12, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Jan 10, 2023

Explanation

Fixes Part of #4195 : Dark mode implementation - Different Interactions items of Questions and Exploration

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Different Interactions

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL, can you please review this PR.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Jan 11, 2023
@MohitGupta121
Copy link
Member Author

The radio button and checkbox have different color as compared to white in dark-mode

Okay I will change it.

@MohitGupta121
Copy link
Member Author

@rt4914 PTAL, now updated the requested changes.
Also updating the PR description screenshots.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 enabled auto-merge (squash) January 12, 2023 16:52
@oppiabot oppiabot bot unassigned rt4914 Jan 12, 2023
@oppiabot
Copy link

oppiabot bot commented Jan 12, 2023

Unassigning @rt4914 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 12, 2023
@rt4914 rt4914 merged commit 607c600 into oppia:develop Jan 12, 2023
@MohitGupta121 MohitGupta121 deleted the dark-mode-interactions branch January 12, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants