Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4791 : Dark Mode the white corners of Stories Cards #4847

Merged
merged 81 commits into from
Jan 25, 2023
Merged

Fixed #4791 : Dark Mode the white corners of Stories Cards #4847

merged 81 commits into from
Jan 25, 2023

Conversation

MohitGupta121
Copy link
Member

Explanation

Fixed #4791 : Dark Mode the white corners of Stories Cards

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Stories Cards corners

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Jan 21, 2023
@oppiabot oppiabot bot added the PR: LGTM label Jan 21, 2023
@MohitGupta121
Copy link
Member Author

@rt4914 can we close this? Or something left?

@MohitGupta121
Copy link
Member Author

@rt4914 I think the check are failing in all PR's.
And Re-run the tests will pass all checks. As I observed.

@rt4914
Copy link
Contributor

rt4914 commented Jan 24, 2023

This can be merged once CI checks pass.

@MohitGupta121
Copy link
Member Author

This can be merged once CI checks pass.

See @rt4914 now it's passed. As I say there is some issue in workflow itself.
I will raised this issues in CLAM meeting today.

@rt4914 rt4914 merged commit 21dd212 into oppia:develop Jan 25, 2023
@MohitGupta121 MohitGupta121 deleted the dark-mode-cards-corner branch January 26, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Dark Mode the white corners of Stories Cards are visible.
2 participants