Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolbar shadow and text cutoff on scrolling to top. #487

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Fix toolbar shadow and text cutoff on scrolling to top. #487

merged 1 commit into from
Nov 29, 2019

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Nov 29, 2019 •
edited

rt4914
rt4914 approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914
Copy link
Contributor

rt4914 commented Nov 29, 2019

Screenshot_1575011425

Just for conext: The toolbar shadow is above the content, which is correct.

@rt4914 rt4914 removed their assignment Nov 29, 2019
@veena14cs
Copy link
Contributor Author

Screenshot_1575011425

Just for conext: The toolbar shadow is above the content, which is correct.

Thanks @rt4914 .

nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veena14cs veena14cs merged commit c68a9bd into develop Nov 29, 2019
@veena14cs veena14cs deleted the hifi-toobar branch November 29, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

Assignees

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veena14cs @rt4914 @nikitamarysolomanpvt