Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Q&A (Installation) discussion form #4877

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Add Q&A (Installation) discussion form #4877

merged 4 commits into from
Feb 25, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Feb 17, 2023

Explanation

Add Q&A (Installation) discussion form

  • This PR does the following: This is so we get all the information required to solve installation problems.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Proof that changes are correct

Screenshot 2023-02-18 at 12 18 16 PM

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @gp201 suggest me in last welfare meeting to do something similar for oppia-android.
@seanlip @gp201 @BenHenning PTAL, I make form similar as per oppia-web.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121! This is interesting. Left a few comments after taking a first pass, PTAL.

.github/DISCUSSION_TEMPLATE/q-a-installation.yml Outdated Show resolved Hide resolved
@MohitGupta121 MohitGupta121 removed their assignment Feb 18, 2023
@seanlip seanlip removed their assignment Feb 19, 2023
@seanlip
Copy link
Member

seanlip commented Feb 19, 2023

@MohitGupta121 I don't think you need a review from me on this. Please check with @gp201 on any dev-workflow-specific issues you run into, but otherwise, once @BenHenning approves this I think you can merge it.

Thanks!

@MohitGupta121 MohitGupta121 removed the request for review from seanlip February 19, 2023 13:29
@MohitGupta121
Copy link
Member Author

@seanlip okay thanks, Waiting for @BenHenning and @gp201 review.

Copy link
Member

@gp201 gp201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gp201 gp201 removed their assignment Feb 20, 2023
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121. I think this looks really good! Excited to see how it works in practice.

@BenHenning
Copy link
Sponsor Member

Though it looks like you have a CI failure @MohitGupta121. Please fix & assign back.

@oppiabot oppiabot bot added the PR: LGTM label Feb 23, 2023
@MohitGupta121
Copy link
Member Author

MohitGupta121 commented Feb 23, 2023

Though it looks like you have a CI failure

Yes @BenHenning I see the checks are failing saying due to CODEOWNER files. So how I can passed that test?
Need to change anything in CODEOWNER file?

I think we need to need CODEOWNER for this file mentioned in the CI Check Failure

What do you suggest Ben is that correct, who is the CODEOWNER?

@MohitGupta121 MohitGupta121 requested a review from a team as a code owner February 23, 2023 05:10
@MohitGupta121
Copy link
Member Author

@BenHenning PTAL, all checks are passed now.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121. This LGTM!

@BenHenning BenHenning merged commit e1d6cfd into oppia:develop Feb 25, 2023
@MohitGupta121 MohitGupta121 deleted the q-a-installation-form branch February 25, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants