Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4888 : Remove the unused condition from lessons_completed_chapter_view.xml for Accessibility #4889

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Fixed #4888 : Remove the unused condition from lessons_completed_chapter_view.xml for Accessibility #4889

merged 2 commits into from
Mar 11, 2023

Conversation

MohitGupta121
Copy link
Member

Explanation

Fixed #4888 : Remove the unused condition from lessons_completed_chapter_view.xml for Accessibility

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL, I updated the file as per the issue.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 enabled auto-merge (squash) March 11, 2023 09:44
@oppiabot oppiabot bot unassigned rt4914 Mar 11, 2023
@oppiabot
Copy link

oppiabot bot commented Mar 11, 2023

Unassigning @rt4914 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Mar 11, 2023
@rt4914 rt4914 merged commit 90347ac into oppia:develop Mar 11, 2023
@MohitGupta121 MohitGupta121 deleted the remove_condition_in_lessons_completed_chapter_view.xml branch March 18, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the unused condition from lessons_completed_chapter_view.xml for Accessibility
2 participants