Fix #3844: Combine chapter listing double string to one string

[kkmurerwa]

Explanation

Fix #3844: When merged, this PR will;

• Remove the R.plurals.chapter_count_with_story_name from the strings file.
• Remove all translations of the R.plurals.chapter_count_with_story_name.
• Delete the computeStoryNameChapterCountContainerContentDescription() method from StorySummaryViewModel which is no longer used.

The approach to delete the above files was necessitated by a change made on PR #4441. The PR switched from a chapter-based progress system i.e. Chapter 1 of 10 to a percentage-based progress system. This made the chapter_count_with_story_name strings and the computeStoryNameChapterCountContainerContentDescription() method used to generate the chapter-based progress text redundant. These have been removed to eliminate this redundancy.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

[BenHenning]

@kkmurerwa is this ready for review? If so, you should "PTAL @<reviewer_name>" in order to kick-off the review process.

[kkmurerwa]

@BenHenning it is ready for review. I hesitated to assign it to you because I assumed it automatically does it once you send a PR. Let me do that right now.

[kkmurerwa]

PTAL @BenHenning

[BenHenning]

Thanks @kkmurerwa! This looks really solid. Just had a few questions on clean-up, thoroughness, and testing--PTAL.

[kkmurerwa]

Hey @BenHenning. I am working on the issues you've identified. I will request for a review once that is done.

[kkmurerwa]

Hey @BenHenning. I have deleted the required files and updated the PR comment.

[kkmurerwa]

PTAL @BenHenning

[oppiabot]

Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks!

[BenHenning]

Thanks @kkmurerwa! Just had one follow-up comment, but can you also update your PR description to reference the PR that originally removed the reference to computeStoryNameChapterCountContainerContentDescription? That will help contextualize the "why this approach is correct" aspect of a clear PR description.

[kkmurerwa]

@BenHenning I have updated the PR comment. Please let me know if it is better now.

[kkmurerwa]

PTAL @BenHenning

[oppiabot]

Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks!

[BenHenning]

Thanks @kkmurerwa. I followed up on the open comment--PTAL.

[BenHenning]

Thanks @kkmurerwa. This LGTM! I'll enable auto-merge so that you can merge this once CI checks are passing and your comment is resolved.

[oppiabot]

Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

[kkmurerwa]

Hi @BenHenning. I'll mark the remaining unresolved comment as resolved once all the checks pass. Thanks.