Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Bug Fix - Remove elevation #493

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Audio Bug Fix - Remove elevation #493

merged 1 commit into from
Dec 1, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 30, 2019

Explanation

In StateFragment, audio was not playable because the entire recyclerview was coming on top of audio player. To fix that I have removed the elevation given to Recyclerview.

Also, if you approve this, directly merge this so that others won't face this issue.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning BenHenning merged commit 1aadd08 into develop Dec 1, 2019
@BenHenning BenHenning deleted the audio-bug-fix branch December 1, 2019 01:05
@BenHenning
Copy link
Sponsor Member

Thanks @rt4914! I didn't actually hit this bug (the audio button seems to work for me locally), but I also don't see a need for us to set an elevation for the recycler view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants